Address compiler warnings - Githubissues

jk-jeon / dragonbox

Reference implementation of Dragonbox in C++

Apache License 2.0

588 stars 37 forks source link

Address compiler warnings #15

Closed johnmcfarlane closed 3 years ago

johnmcfarlane commented 3 years ago

Hi Here are a few changes that would silence some compiler diagnostics which are common when warnings are elevated. Thanks John

g++ 10.2.0 (settings):

dragonbox.h:206:48: error: declaration of ‘u’ shadows a member of ‘jkj::dragonbox::ieee754_bits’ [-Werror=shadow]
dragonbox.h:701:57: error: conversion from ‘long unsigned int’ to ‘int’ may change value [-Werror=conversion]
dragonbox.h:660:19: error: comparison of integer expressions of different signedness: ‘int’ and ‘const size_t’ {aka ‘const long unsigned int’} [-Werror=sign-compare]

clang 11.0.0 (settings):

dragonbox.h:2113:51: error: unused parameter 'fp' [-Werror,-Wunused-parameter]