search

jk-jeon / dragonbox

Reference implementation of Dragonbox in C++
Apache License 2.0
588 stars 37 forks source link

Remove some C style casts #39

Closed rodericktaylor closed 1 year ago

rodericktaylor commented 1 year ago

My project uses GCC and has -Werror and -Wold-style-cast compiler options set to catch bad pointer casting practices. While the lines I've changed aren't necessarily bad usage of the old style cast, the are collateral damage in the war against bugs. I'm only using dragonbox.h in my project so other files haven't been changed.

Thanks for a great library.

jk-jeon commented 1 year ago

Looks good, thanks. The only problem is that now the code style is a bit inconsistent, but I think I will at some point overhaul cast and literal constant usages so it should be no problem.