Minor compatibility fixup

jk-jeon / dragonbox

Reference implementation of Dragonbox in C++

Apache License 2.0

607 stars 39 forks source link

Closed malachib closed 6 months ago

malachib commented 7 months ago

Changed two things:

CLang/ARM64 can't quite resolve unsigned long long == unsigned long despite them both being 64-bit unsigned integers. Comparing those two via numeric limits now
Presumed a default parameter for compressed_cache_detail of ieee754_binary64. If I got that wrong, my feelings won't be hurt and you can reject the PR :)

malachib commented 7 months ago

Two issues need attention before this is a viable PR:

I forgot use stdr namespace. Oops
I'm feeling there's a better way to compare the two than max() thought max() is reasonable

jk-jeon commented 6 months ago

I'm closing this because I came up with a different method of dealing with unsigned long long vs unsigned long issue in a recent commit.