fix, tidy: cmake project was failing to configure.

jk-jeon / fp

IEEE-754 binary-to-decimal and decimal-to-binary conversion library

40 stars 5 forks source link

fix, tidy: cmake project was failing to configure. #3

Closed biojppm closed 3 years ago

biojppm commented 3 years ago

the main point is fixing a problem in add_test() where NAME was not available (it cannot be both an explicit macro argument and an entry to cmake_parse_arguments())

Also, refactored some boilerplate cmake code to functions, and organized the project into folders:

jk-jeon commented 3 years ago

Thanks for the PR. I like all of changes you made. But could you explain what buffer.h is?

biojppm commented 3 years ago

could you explain what buffer.h is?

Oh, sorry - that was not meant to go in yet; it will be the subject of a future PR - but not yet. I will amend the commit.

biojppm commented 3 years ago

Done.

jk-jeon commented 3 years ago

Thanks again!