jkall / qgis-midvatten-plugin

Midvatten plugin for QGIS
23 stars 8 forks source link

custom plot discontinuous plot must be default 0 #312

Closed jkall closed 5 years ago

jkall commented 5 years ago

branch simon_merge:

It seems that default time step is 1 for discontinuous plotting in custom plot. Hence many series will be discontinuous. Should be reverted to previous behaviour, time step = 0, to always start with continuous plots unless user changes this value.

In addition: When plot type is "markers" (and not "plot and markers") then some data points are not plotted at all when selecting time step 1. (Expected behaviour is to plot all markers but discontinue the line whenever time step between data points exceed 1 day).

HenrikSpa commented 5 years ago

Ongoing fix (soom pushed):

value 0.0: image

Value 0.05 (hourly timesteps):

image

// Workaround for numpy version 1.13.3

image

Also works with float x and y

image

HenrikSpa commented 5 years ago

When I start a completely blank projekt and add a sqlite database, the value is set to 0,00 (default).

It also remembers the last used value when I exit qgis (and save projekt) and loads it again.

HenrikSpa commented 5 years ago

Fixed in master, qgis3_henrik and simon_merge. @jkall Please test it and close if you agree that it works.

jkall commented 5 years ago

@HenrikSpa OK, defaults to 0. But python error when using time step=1 and plot type=marker (tested to plot w_levels - level_masl, obsid and db as in screenshot): image

(tested on the simon_merge branch)

HenrikSpa commented 5 years ago

Odd.

It worked for me:

import numpy as np print(np.version) 1.16.1

I tried the same, I think, see image (in mail)

HenrikSpa commented 5 years ago

I reinstalled numpy version 1.13.3 and I also get that error message now.

HenrikSpa commented 5 years ago

Found a solution for 1.13.3

See comparable image in previous post.

HenrikSpa commented 5 years ago

Also works with 1.16.2.

Closing the issue. It can be reopened if encountered again.