jkanyi-web / space-travellers

This is a web application for a company that provides commercial and scientific space travel services and works with the real live data from the SpaceX API. The application will allow users to book rockets and join selected space missions.
1 stars 0 forks source link

Space-Travellers project setup #21

Open jkanyi-web opened 1 year ago

jkanyi-web commented 1 year ago
DammyShittu commented 1 year ago

Hi @jkanyi-web and @LDouglasOT,

While you made a great effort in this project, I cannot proceed to review your code.

Invalid Code Review Request

You need to provide the link to the Kanban board.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


Invalid Code Review Request does not count into the code reviews limit.

AdnanOlarmmi commented 1 year ago

Hi @jkanyi-web and @LDouglasOT,

This is Adnan Is-haq, your beloved code reviewer,

You've done a very good job so far, but a few things still need to be worked on before moving on to the next project, but you're so close!

You're Almost there, funny one eyed alien

Highlights

Required Changes ♻️

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.

Cheers, and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

jkanyi-web commented 1 year ago

I've clicked on the react group project template yet the javascript template is the one being copied. Can you please help me out on this?

abdulhamiid commented 1 year ago

:green_circle: Approved! :partying_face:

Hi Team 👋, image Your project is complete! Congratulations! 🎉

Highlights 🌟

Optional suggestions 🤷‍♂️

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Important Notes 📝

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.