search

jkarsrud / ember-cli-defeatureify

Ember-CLI addon to defeatureify your apps
MIT License
18 stars 6 forks source link

Move to modules. #16

Closed nathanhammond closed 10 months ago

nathanhammond commented 8 years ago

ember-cli-defeatureify presently requires globals since the processing for feature stripping does a string comparison on the variable path. This PR implements a solution that allows for importing of the feature configuration as a module and removes globals. As a consequence there is no longer any need to specify namespace as that will consistently be the module name.

This also dramatically reduces the complexity of the addon. I've also ported it to an up-to-date blueprint.

Depends on https://github.com/ember-cli/ember-cli/pull/5233/ landing in order to support configuration in a meta tag.

Closes #15.

nathanhammond commented 8 years ago

Also, @jkarsrud, I've added you as a collaborator to my fork in case you want to modify this PR so you can do so directly in my fork.

jkarsrud commented 8 years ago

@nathanhammond I've given you commit access to this repo now, so feel free to do changes as you wish. I don't really use this addon anymore, so it's better if someone who actually does maintains it :)

nathanhammond commented 8 years ago

@jkarsrud Awesome, thanks! We're still looking for the world's most ridiculous bug which is preventing https://github.com/ember-cli/ember-cli/pull/5233 from landing, but that's really the only thing left.

erkie commented 7 years ago

Any chance of getting this merged? Looking forward to getting rid of the deprecation:

DEPRECATION: The `app-prefix` hook used in ember-cli-defeatureify is deprecated. The addon should generate a module and have consumers `require` it.

:D