search

jkarsrud / ember-cli-defeatureify

Ember-CLI addon to defeatureify your apps
MIT License
18 stars 6 forks source link

DEPRECATION: Overriding init without calling this._super is deprecated #19

Closed adamreisnz closed 8 years ago

adamreisnz commented 8 years ago 
DEPRECATION: Overriding init without calling this._super is deprecated. 
  Please call `this._super.init && this._super.init.apply(this, arguments);` addon: `ember-cli-defeatureify`

Version 1.1.1 and ember-cli version 2.6.2.

adamreisnz commented 8 years ago

Is anyone still maintaining this package?

@nathanhammond I see you've forked this and did some more work on it here https://github.com/nathanhammond/ember-cli-defeatureify, are you able to merge those changes in and fix the deprecation warnings?

dwickern commented 8 years ago

I've been staring at this deprecation for a while now. It's a trivial fix. I'd be happy to open a PR if there's someone around who can merge it and make a release.

nathanhammond commented 8 years ago

@dwickern Would you be willing to update the Ember CLI version for this addon? I have commit privs but not publish. Part of the way there is better than nothing. :P

jkarsrud commented 8 years ago

A PR is most welcome @dwickern!

I added you as a collaborator on npm now, @nathanhammond, so I guess you should be able to publish now :)

nathanhammond commented 8 years ago

@jkarsrud Why, thank you! Will take good care of things, promise. ❤️

nathanhammond commented 8 years ago

v1.1.2 published.

adamreisnz commented 8 years ago

Awesome guys, thanks for looking into it.

adamreisnz commented 8 years ago

@Actually still getting a deprecation warning:

DEPRECATION: The app-prefix hook used in ember-cli-defeatureify is deprecated. The addon should generate a module and have consumers require it.

Are you able to address that one as well? I can raise a separate issue for it.

nathanhammond commented 8 years ago

@adambuczynski That's https://github.com/jkarsrud/ember-cli-defeatureify/pull/16 ... but it depends on https://github.com/ember-cli/ember-cli/pull/5582 which is blocked on spooky action at a distance in the Ember CLI test suite that I've not been able to figure out in spite of 40+ hours of research.

adamreisnz commented 8 years ago

I see, yes, thanks. I'll ignore that message for the mean time then. 👍