search

jkarsrud / ember-cli-defeatureify

Ember-CLI addon to defeatureify your apps
MIT License
18 stars 6 forks source link

Handle namespaces with spl.operators #7

Closed sivakumar-kailasam closed 9 years ago

sivakumar-kailasam commented 9 years ago

Ember cli handles namespaces with special operators like + - which would otherwise cause issues by using array notation as 'window["' +namespace + '"]' . I've made the necessary changes with this PR.

sivakumar-kailasam commented 9 years ago

@jkarsrud does this PR look good to you?

jkarsrud commented 9 years ago

@sivakumar-kailasam I'm not sure I completely understand what you mean, but looking at the code, I think I get it. You're talking about namespaces like ember-cli-defeatureify, which wouldn't be set properly because of the '-' character? If you could confirm, I'd be happy to merge!

sivakumar-kailasam commented 9 years ago

Yep that's the case. On Feb 13, 2015 1:09 PM, "Jesper Haug Karsrud" notifications@github.com wrote:

@sivakumar-kailasam https://github.com/sivakumar-kailasam I'm not sure I completely understand what you mean, but looking at the code, I think I get it. You're talking about namespaces like ember-cli-defeatureify, which wouldn't be set properly because of the '-' character? If you could confirm, I'd be happy to merge!

— Reply to this email directly or view it on GitHub https://github.com/jkarsrud/ember-cli-defeatureify/pull/7#issuecomment-74216130 .