jkaving / intellij-colors-solarized

Solarized Colorscheme for IntelliJ IDEA
3.26k stars 428 forks source link

Some issues in IntelliJ 15 #108

Closed OOPMan closed 8 years ago

OOPMan commented 9 years ago

I've noticed a couple of issues in IntelliJ 15. Adding some screen-area caps.

image

image

OOPMan commented 9 years ago

If I find any more, I'll add.

aik099 commented 9 years ago

Where is the issue exactly? If you mean, that code block at cursor is highlighted incorrectly, then this isn't color scheme issue it seems.

OOPMan commented 9 years ago

Well, in the first image, the background colour highlighting is misbehaving. If I move the cursor to a blank line then the entire line gets highlighted whereas in the image certain areas are not being highlighted.

In the second image, the background/foreground colour combination highlighting the div tag is highly unreadable.

I'm not sure if this is Solarized's fault? I just upgraded from IntelliJ14 to IntelliJ15 and these two things stood out...should I harass JetBrains instead?

EDIT: Interesting. Just opened the Settings -> Color & Fonts -> General page and preview area seems to be behaving normally...

EDIT: Oh wait, the first thing is happening because of some new colour settings. And the second as well. Nevermind, sorry for the ticket.

jkaving commented 9 years ago

Well, the second image definitely shows a problem.

I have been experimenting with using a lighter shade of green (#DDDEB1) for matched braces:

screenshot of intellij idea-eap 2015-11-05 11-02-13

I think this looks much better, and I think this a case were we should use a non-Solarized color to make the scheme usable.

Unfortunately, the matched brace setting is used for all parentheses and braces - and it is only for XML/HTML tags that it becomes a problem. But I think this looks ok as well:

screenshot of intellij idea-eap 2015-11-05 11-07-48

What do you think?

OOPMan commented 9 years ago

Yes, agreed. I noticed that all of the tag level values are pretty bright but only the green one seems to really cause eye-pain :-)

aik099 commented 8 years ago

Agreed. Don't forget about Solarized Dark theme as well.