search

jkaving / intellij-colors-solarized

Solarized Colorscheme for IntelliJ IDEA
3.26k stars 432 forks source link

Suggestion: Use Darcula font in Darcula themes #116

Closed pedroadame closed 8 years ago

pedroadame commented 8 years ago

Hi! IDEA uses a more legible font in Darcula theme. I think you should use it too!

aik099 commented 8 years ago
  1. Which font you're suggesting?
  2. Not sure if it's possible to specify font as part of imported Color Scheme.
jkaving commented 8 years ago

At least on Mac OS X it seems as if both the Default scheme and the Darcula scheme specify Menlo as the font:

screenshot_of_intellij_idea screenshot_of_intellij_idea

And yes, unfortunately the color schemes does specify the font - see https://github.com/jkaving/intellij-colors-solarized#note-about-fonts.

@Kinnonii - Could you provide screenshots of what you mean?

pedroadame commented 8 years ago

@aik099 @jkaving In Windows & Linux the font used in Darcula theme by default is Source Code Pro and in the light theme is DejaVu Sans Mono which is used in the Solarized Dark (Darcula) theme too.

Look at the (big) difference image image

jkaving commented 8 years ago

I actually use the Source Code Pro font myself. It might actually be better to specify that in the Solarized color scheme files.

The Solarized color scheme files currently specify the Menlo font, which I believe is only included by default in OS X. So I guess the fonts you get on Windows and Linux are default fonts that IntelliJ IDEA uses when the specified font is not available. It is possible that IntelliJ IDEA uses different default fonts for the Darcula Look&Feel and the Default Look&Feel.

pedroadame commented 8 years ago

@jkaving In fact it's true, it uses differents font by default. Probably is better to set Source Code Pro as the default font as it's shipped by default with the IDE.

jkaving commented 8 years ago

Probably is better to set Source Code Pro as the default font as it's shipped by default with the IDE.

Oh, that's cool - I didn't know that. It actually seems to have been included since 2012 (see https://github.com/JetBrains/intellij-community/commit/629a6f2cf719e6dffc78431a4b8f1f2fe4c11ed0).

Then it is definitely better to specify that in the color scheme files. I will change it.

pedroadame commented 8 years ago

@jkaving Very cool! Thank you :)

jkaving commented 8 years ago

Actually, it seems as if it is no longer necessary to include a font in the color scheme file. This is probably an effect of the switch to the .icls format (see #51 and #53) and the fact that the color schemes now specify a parent scheme that they inherit settings from.

So an even better solution is probably to remove the font information from the Solarized color schemes. You will then get the default font for your OS. I will need to investigate whether Solarized Dark should specify Darcula as its parent scheme.

alexrayu commented 8 years ago

FUI, for me in PHPStorm 2016.1, css color icons do not show when using Darcula with Source Code Pro.