Wrong Parameter Or Argument Colors For Variables

[ghost]

Variables which are arguments or parameters, have wrong colors in PHP. Regular variable declarations are correct (blue). See the picture below for the problem:

I am using IntelliJ version 2016.1.1

[aik099]

Which color is wrong?

Here is how it works:

• blue - variable declared inside the method
• orange - method parameter

Before both were blue, but this was changed to allow easily seeing which variables come from outside of method.

[ghost]

The color of the method parameter is wrong. The color above is the default color if no color was specified (brownish). All old syntax themes have these issues because Jetbrains changed something with the version 15. I also use the material syntax theme for Jetbrains, it had the same issue (thus the same color for method parameters) but was updated recently.

[aik099]

Can you please post screenshot of same code with Solarized Dark theme?

[aik099]

And to compare screenshots from Solarized Light & Solarized Dark from previous PhpStorm versions where it worked as you expect.

[jkaving]

I think we just need to add an element for PHP_PARAMETER. Like this commit for the material theme.

[jkaving]

Now I realize that commit 8a50bbe66c5f7d6460672f5dae2fdc45c4d71cbc by @aik099 actually added the PHP_PARAMETER - but only for Solarized Dark. I will add it for Solarized Light as well.

[ghost]

Wow, thanks for the quick fix!