search

jkaving / intellij-colors-solarized

Solarized Colorscheme for IntelliJ IDEA
3.26k stars 432 forks source link

PhpStorm 2017.1.1 wrong class method color #145

Closed aik099 closed 7 years ago

aik099 commented 7 years ago

2017-04-07_1046

The class method color in color scheme preview is shown as grey (correct), but actually in the editor it's shown as yellow.

It was working before (I had another copy of Solarized Dark theme), but in my copy inline parameter type hints are shown incorrectly and that's why I went to try latest version of theme.

aik099 commented 7 years ago

After some clicking in color scheme editor I've found out that method name in class is detected as Identifiers > Default, but in editor it works as Functions and Methods declaration, which indeed is of orange color.

Now I guess it's time to ask if this was an intended change, because now my PHP class looks like a rainbow with all method names in orange.

jkaving commented 7 years ago

We seem to have discussed this quite a bit in issue #58 :-) See my comment here.

aik099 commented 7 years ago

Ha-ha. So I was initiator of this change, but I wasn't upgrading to new color scheme version for 1.5 year to see that change was actually made 😄

I guess then this and discussion you've mentioned can be closed.