jkaving / intellij-colors-solarized

Solarized Colorscheme for IntelliJ IDEA
3.26k stars 432 forks source link

colors of solarized blend in with background colors #149

Closed torian257x closed 7 years ago

torian257x commented 7 years ago

this is in intellij 16.3 and phpstorm

i was looking at the http://ethanschoonover.com/solarized theme for coding. I wanted to switch from bright to dark. Why? because I saw a video with someone using the dark theme with nice colors. I liked more colorful, so I wanted to switch. I love the colorized colors... but things are hard to read. Quite the opposite of what was promised...

compare:

$user
->fresh()
$stripe_email

in intellij bright, I think it is always quite easy to read those. In solarized, the fonts do not look sharp and seem to blend in with the background.

once it is very easy to read, under solarized it is quite ugly to read

what causes this?

intellij standard easy to read IMHO: image

Solarized, things blend in, for example $user. $donor is an example that does NOT blend in:

enter image description here image

zoomed in:

image

image

aik099 commented 7 years ago

The only notable difference, that I've spotted is $user variable colored in orange. Is that what's you're concerned about?

It is because function/method parameter color is set to orange. You can override this in theme settings if you'd like. This way it's easier to spot accidental replace of function/method parameter value.

torian257x commented 7 years ago

hi @aik099 first of all i love the solorized theme, dont get me wrong.

to your question: the color is orange yes, but not only that. look in the zoomed in version.

in my opinion clearly $user in intellij white and ->fresh are both a lot better readable than the version of solarized. There is just no doubt about it for me. An example where this is not the case is $donor $donor is equally well readable in intellij white and solarized.

so yes, the colors must just be poorly chosen or this is an effect nobody has noticed before me? or people just use bigger font-size? (i use 10px). Or is there a different explanation? it seems that some letters, when getting thinner, depending on their color, start blending in more or less with the background color. Look at the u of $user look at the right side of that u. The intellij white gets a brighter red, still very good to read, the solarized dark gets half dark. This pattern follows through all those letters. The e in $user in solarized looks as if it has some black spots in it. This is the case as well in intellij white, just a lot less notable. Maybe because the colors are not as close as the orange and background?

now of course I can change the color myself of the texts and/or the background color

but just wanted you guys know

maybe you knew this before as a common issue. Or i use a bad font? its mono spaced deja vu

aik099 commented 7 years ago

I'm using Menlo font of 13px size with 1.2 line spacing with anti-aliasing enabled. Looks good.

jkaving commented 7 years ago

In part I think that what you are seeing is actually something that the Solarized color scheme was designed to do - that is, have a lower contrast. This text is from the main Solarized page:

1. Selective contrast On a sunny summer day I love to read a book outside. Not right in the sun; that’s too bright. I’ll hunt for a shady spot under a tree. The shaded paper contrasts with the crisp text nicely. If you were to actually measure the contrast between the two, you’d find it is much lower than black text on a white background (or white on black) on your display device of choice. Black text on white from a computer display is akin to reading a book in direct sunlight and tires the eye.

Solarized reduces brightness contrast but, unlike many low contrast colorschemes, retains contrasting hues (based on colorwheel relations) for syntax highlighting readability.

But in your zoomed-in screenshot I agree that there seems to a problem with the characters and the anti-aliasing making them look to fuzzy. I guess this effect is related to both the font-size as well as the screen resolution, so perhaps increasing the font-size might help.

torian257x commented 7 years ago

the thing is I noted is that this effect does not apply with all colors. So I started chaning font colors to brighter colors and am ok now

screen resolution -> do you think a higher res screen would yield better results? i have only 1920x1080

maybe retina displays would improve that effect?

jkaving commented 7 years ago

A retina display definitely seems to help. Here are two screenshots of the orange color where I changed my font to 10 pt Menlo.

The first one is taken on my MacBook Pro 15" with retina screen:

screenshot of intellij idea 2017-06-07 10-07-09

And this one is on my external Philips 272S4L, a 27" screen with 2560x1440 resolution:

screenshot of intellij idea 2017-06-07 10-14-01