search

jkaving / intellij-colors-solarized

Solarized Colorscheme for IntelliJ IDEA
3.26k stars 430 forks source link

.cshtml file in Rider has wrong color for html tags #154

Closed bradleylandis closed 7 years ago

bradleylandis commented 7 years ago

html files have the tag names in blue and bold, but in the .cshtml file it comes out dark red on the dark blue background and is difficult to read.

image

jkaving commented 7 years ago

As noted in #150 there is very little support for Rider/C#/.NET

Pull requests for this would be welcome.

bradleylandis commented 7 years ago

@jkaving If you can point me in the right direction, I'd love to help out.

jkaving commented 7 years ago

I usually use the Preferences dialog in IntelliJ IDEA (under Editor->Color Scheme) to tweak the colors, trying to limit myself to the official Solarized colors.

In the top of the dialog it is possible to select which scheme to modify (Solarized Light or Dark - the Darcula versions can be skipped since they are automatically generated by the build script in this repo).

After saving the changes I usually copy the color scheme files from the IntelliJ IDEA preferences directory to my working copy of this repo (see the manual installation section in the README for the location for different OSes). The diff might need to be inspected a bit since there might be unnecessary changes that IDEA has done when saving the color scheme file, but it is usually relatively easy to figure out which changes correspond to the changes made in the Preferences dialog.

Before committing the changes I try to make sure to run the buildjar.sh script to generate an updated version of the settings.jar file and include that in the commit.

bradleylandis commented 7 years ago

Thanks. I gave it a shot, but it's not working. I filed a bug with Rider team https://youtrack.jetbrains.com/issue/RIDER-8913?query=colors%20asp.net

bradleylandis commented 7 years ago

The rider team says this bug was fixed in 2017.2 which is out now. I haven't verified it yet.

bradleylandis commented 7 years ago

okay, I may have misunderstood... it looks like they marked it "To be fixed in 2017.2" but it doesn't appear to be fixed in the current EAP of 2017.2

bradleylandis commented 7 years ago

I can confirm this is fixed in 2017.2 EAP 2. You can close this issue

jkaving commented 7 years ago

Perfect - thanks for letting us know!