search

jkaving / intellij-colors-solarized

Solarized Colorscheme for IntelliJ IDEA
3.26k stars 432 forks source link

Update README for Phpstorm 2018.3 #169

Closed Lucky-Loek closed 5 years ago

Lucky-Loek commented 5 years ago

I just noticed that in Phpstorm 2018.3 has changed the way you should import settings. I've updated the README accordingly.

afbeelding

jkaving commented 5 years ago

Thanks for noticing this.

I tried it in IntelliJ IDEA and there is an additional choice you need to make there - whether to import an IntelliJ IDEA color scheme or an Eclipse color scheme:

screenshot of intellij idea 2018-11-26 13-15-18

But I tested PhpStorm (2018.3) and the old way of importing color scheme still works, as it does in IntelliJ IDEA as well. So rather than replace the existing description it might be better to add a separate section in the README for this third way of installing the color scheme.

Lucky-Loek commented 5 years ago

Oh hey, then apparently the macOS and Windows version are more different than I thought. I can't test macOS, but I can write up a third way? Or shall we just close this as no one has created an issue yet? Writing up three different installation methods is probably more confusing than keeping the one that seems to work fine.

jkaving commented 5 years ago

Ah - I didn't realise you were on Windows (which is hard for me to test). Doesn't the old way work on the Windows version?

Lucky-Loek commented 5 years ago

EDIT:

This might actually be due to some setting on my pc, as the action still exists but is disabled for some reason.

afbeelding

jkaving commented 5 years ago

Strange.

The menu alternatives are still documented here: https://www.jetbrains.com/help/phpstorm/exporting-and-importing-settings.html

I found this issue (created yesterday) in JetBrains' issue tracker: https://youtrack.jetbrains.com/issue/WI-44325

Perhaps we should wait for the response to the issue but I guess it might make sense to replace the current description with one that works on both OS:es.

jkaving commented 5 years ago

There's a comment on the JetBrains issue now: https://youtrack.jetbrains.com/issue/WI-44325#focus=streamItem-27-3179336-0-0

The reporter is asked to disable the Settings Repository plugin.

Lucky-Loek commented 5 years ago

Disabling both Settings Respository and Settings Sync plugins reveals the "import settings" function for me again. I'll close this as it's obviously at JetBrains' side instead of yours. Hope they'll fix it though, now I have to manually import your schemes into 4 IDEs haha

jkaving commented 5 years ago

Well, thanks for the effort! And let's hope they fix it.