2018.3 Hints - Githubissues

jkaving / intellij-colors-solarized

Solarized Colorscheme for IntelliJ IDEA

3.26k stars 432 forks source link

2018.3 Hints #170

Closed NicolasSiver closed 5 years ago

NicolasSiver commented 5 years ago

Hello,

Anybody is working on a better support for hints (JavaScript) introduced in 2018.3? Currently, it does not look well with Solarized Dark.

aik099 commented 5 years ago

The hints for PHP were there for some time. Any reference to YouTrack about that feature?

jkaving commented 5 years ago

I agree that this doesn't look good on Solarized Dark.

The relevant settings seems to be here: screenshot_of_screenfloat It seems to be primarily the Current and Highlighted variants that need to be fixed.

Any suggestions for better colors?

NicolasSiver commented 5 years ago

We could make them the same color as Function Call colors. It will "disable" these extra states. The value of highlighted hint is questionable.

Or...

The background is always the same to signal hint shape, but grey -> white -> teal (close to white) used to signal selection differences.

Or...

To not use teal as it's often used with Strings, but use purple because it's quite a rare color in the theme and will not interfere with potential String next to it.

jkaving commented 5 years ago

I have now merged #171 - thanks!