search

jkaving / intellij-colors-solarized

Solarized Colorscheme for IntelliJ IDEA
3.26k stars 430 forks source link

Fix wrong italic #179

Closed soshial closed 12 months ago

soshial commented 3 years ago

Changes:

  1. What? DEFAULT_STATIC_FIELD should be italic Why? All Static fields and functions are italic in the default IntelliJ theme. Solarized should adhere to this. Changes. (Language Defaults) Classes-> Static field changed to italic. Effects. (Kotlin) Properties and variables -> Extension property became is italic by inheritance. Example. See line 18 on the screenshot.

  2. What? STATIC_FIELD_ATTRIBUTES in Java should be italic Why? All static fields are italic in the default IntelliJ theme. Solarized should adhere to this. Changes. (Java) Classes -> Static field changed to inherit from (Language Defaults) Classes-> Static field

  3. What? KOTLIN_CONSTRUCTOR shouldn't be italic (PR https://github.com/jkaving/intellij-colors-solarized/pull/183) Why? Java constructors are not italic, hence Kotlin constructors shouldn't be either Changes. (Kotlin) Functions -> Constructor call changed to inherit from (Language Defaults) Identifiers -> Function call Example. See line 14 on the screenshot.

  4. What? STATIC_METHOD_ATTRIBUTES in Java should be italic (#8668ace) Why? All static methods are italic in the default IntelliJ theme. Solarized should adhere to this. Changes. (Java) Methods -> Static method changed to inherit from (Language Defaults) Classes -> Static method

PS. Probably the same edits should be done for Solorized Dark.

soshial commented 3 years ago

See lines 14 and 18.

IntelliJ default: image

Before this FIX: image

After the FIX: image

soshial commented 3 years ago

@jkaving, do you mind having a look at these changes?

jkaving commented 9 months ago

I've now done the changes suggested here and closed #157