search

jkaving / intellij-colors-solarized

Solarized Colorscheme for IntelliJ IDEA
3.26k stars 430 forks source link

The "Color Scheme deprecation" notification in PhpStorm 2022.2 #180

Closed aik099 closed 9 months ago

aik099 commented 2 years ago

After upgrading to the PhpStorm 2022.2 I've started to get a "Color Scheme deprecation" notification on each PhpStorm startup with the following text:

You are using the Solarized Dark bundled color scheme which will soon be deleted. Consider enabling the Solarized Dark theme instead

Enable Solarized Dark Theme

The Enable Solarized Dark Theme text is a link for downloading/installing Solarized Themes IntelliJ plugin (see https://plugins.jetbrains.com/plugin/12784-solarized-themes). That plugin is well made, however, editor colors aren't as detailed as in this project.

I've installed themes via importing the settings.jar file from this project.

Any idea? Would PhpStorm drop support for custom themes or is it just incorrectly reporting them as deprecated?

gucheen commented 2 years ago

I've tried https://github.com/subtheme-dev/solarized, better than plugins.jetbrains.com/plugin/12784-solarized-themes . However, it still has some problems, code completion popup, for example.

aik099 commented 2 years ago

@jkaving , ping.

jkaving commented 2 years ago

@jkaving , ping.

@aik099 - Sorry for not responding. As can be seen from the commit log I haven't updated this repo at all for a few years - it's kind of amazing that it still works as well as it does (I still use it). One of the reasons that I lost interest was the new Theme support that was added, and I didn't have time to convert this to a theme at the time. Others were quicker to create themes and I kind of assumed that those would replace this color scheme.

I also get the same warning as you in IntelliJ IDEA. Looking at the IntelliJ source code I find the warning string here:

notification.content.solarized.color.scheme.deprecation.enable=You are using the {0} bundled color scheme which will soon be deleted. Consider enabling the {1} theme instead

It was added in this commit: https://github.com/JetBrains/intellij-community/commit/f36fcdc66b827b760e4d52b87acb40b1cc793ec6

I found this old issue where it seems as if Solarized has been bundled with some of the apps (but not all). This other issue was closed in 2019 with the comment:

We now offer themes for download through the plugin manager; we don't plan to bundle any additional themes.

I'm not sure what it is they are preparing for now - if they are planning to only support installing color schemes via theme plugins?

I like confining the custom color scheme to the editor and I don't want the whole UI to be colored according to Solarized. Perhaps a way forward would be to convert this color scheme into a theme that only changes the editor. Users could then choose between that and the existing Solarized themes that re-colors the whole UI.

aik099 commented 2 years ago

As can be seen from the commit log I haven't updated this repo at all for a few years - it's kind of amazing that it still works as well as it does (I still use it).

I use it every working day as well.

One of the reasons that I lost interest was the new Theme support that was added, and I didn't have time to convert this to a theme at the time. Others were quicker to create themes and I kind of assumed that those would replace this color scheme.

Right now when installing a theme it also installs a connected editor color scheme. So I guess JetBrains is just advertising themes feature, but not removing editor color schemes feature.

Since it's a deprecation warning, then I guess it all will work till 31 Dec 2022. After that, we'll see what will happen.

soshial commented 9 months ago

Is the deprecation warning still in place, @jkaving?

BTW, I saw several Solarized themes for Jetbrains IDE: 1, 2.

jkaving commented 9 months ago

Is the deprecation warning still in place, @jkaving?

I didn't get it after adding a space to the end of the color scheme names.

jkaving commented 9 months ago

BTW, I saw several Solarized themes for Jetbrains IDE: 1, 2.

Yes, that's what I meant with this in my earlier comment:

One of the reasons that I lost interest was the new Theme support that was added, and I didn't have time to convert this to a theme at the time. Others were quicker to create themes and I kind of assumed that those would replace this color scheme.

aik099 commented 9 months ago

One of the reasons that I lost interest was the new Theme support that was added, and I didn't have time to convert this to a theme at the time. Others were quicker to create themes and I kind of assumed that those would replace this color scheme.

@jkaving , in your theme the choice of colors is better.