search

jkaving / intellij-colors-solarized

Solarized Colorscheme for IntelliJ IDEA
3.26k stars 432 forks source link

Fix constructor in Kotlin #183

Closed soshial closed 8 months ago

soshial commented 10 months ago

Constructors should NOT be italic. In other themes they inherit from "Identifiers -> Function calls".

Compare with Intellij Light and Intellij Dark (see 3rd line: val ints = java.util.ArrayList<Int?>(2)):

Screenshot 2023-10-30 at 8 46 46 Screenshot 2023-10-30 at 8 53 27

Solarized Light, BEFORE:

Screenshot 2023-10-30 at 8 44 59

Solarized Light, AFTER:

Screenshot 2023-10-30 at 8 46 11

Solarized Dark, BEFORE:

Screenshot 2023-10-30 at 8 52 26

Solarized Dark, AFTER:

Screenshot 2023-10-30 at 8 52 38
soshial commented 9 months ago

@jkaving , please have a look at this.

soshial commented 8 months ago

Do you mind having a look at this bugfix, @jkaving?

jkaving commented 8 months ago

@soshial - Sorry about not merging this earlier.

Thanks for the fix - and the work you put in creating the PR 👍

jkaving commented 8 months ago

See the beginning of my comment here for a bit of an explanation for why I've not been very active in updating this color scheme.

soshial commented 8 months ago

Thanks a lot, @jkaving, for resolving all the issues stacked up during last years. Appreciate it!

jkaving commented 8 months ago

Thanks a lot, @jkaving, for resolving all the issues stacked up during last years. Appreciate it!

Thanks @soshial for nagging me about it!

I've felt bad about ignoring this repo for years. So it felt really good to be able to fix quite a lot yesterday (even if it meant that I got a bit less sleep than ideal last night 🙂).