jkaving / intellij-colors-solarized

Solarized Colorscheme for IntelliJ IDEA
3.26k stars 432 forks source link

Fix comments colours #184

Open soshial opened 8 months ago

soshial commented 8 months ago

Intellij Light (all are grey):

Screenshot 2024-01-05 at 18 29 38

Argument 1:

According to the official documentation the comments should be of base1 colour #93a1a1: image

Argument 2:

An example for Java(Vim) from the official documentation:

image

Before this PR change:

This PR changes to this:

jkaving commented 8 months ago

The comment colors was discussed quite a bit back in #67, #127, #152 and #155.

From #155:

To summarise it:

  • Yes, it is intentional
  • Javadoc comments are grey (or green, for Solarized Light) to be more unobtrusive This is a difference from the original Solarized theme where Javadoc comments are red
  • Line comments are red - to stand out more (argued for in this article)

Perhaps a section about intentional differences from the original Solarized should be added to the README.