search

jkaving / intellij-colors-solarized

Solarized Colorscheme for IntelliJ IDEA
3.26k stars 432 forks source link

CLion support #92

Open MikiGrit opened 9 years ago

MikiGrit commented 9 years ago

Support for new C++ IDE by JetBrains (CLion) would be nice :). Because some highlights are unusual.

jkaving commented 9 years ago

Yes, that would be nice. I don't use C++ at all so I doubt that I will add this support myself. But pull requests are welcome.

I have added C and C++ as unsupported languages in README.md (fd64c8408487c3f70e6abbbf23118871e9397130).

AbigailBuccaneer commented 9 years ago

In the latest CLion (RC, build 141.352.13) there are included color schemes called "Solarized Dark" and "Solarized Light", but they're completely wrong.

Given that they've already added them, it seems likely that this is now a problem for Jetbrains to deal with.

jkaving commented 9 years ago

@AbigailBuccaneer, thanks for noticing the bundled schemes in CLion. I have reported an issue to JetBrains about this: https://youtrack.jetbrains.com/issue/CPP-3076

AlexJF commented 9 years ago

Created 2 versions of the Dark Solarized theme for CLion:

https://gist.github.com/AlexJF/b4530f0df83a312e4bac

Had a look at the contents but the C/C++ colors do not appear to be all prefixed by CPP (could only find CPP_KEYWORD) so it might conflict with existing entries if merged directly into the existing .ics in the repository. Most actually appear to be with an OC prefix but I guess this would clash with ObjectiveC?

AbigailBuccaneer commented 9 years ago

@AlexJF the parsed element types (if not the parsing itself) is mostly shared between ObjectiveC and C/C++ - if you have a peek at a C++ file in PsiViewer, you'll see that everything uses Language: ObjectiveC. This is because the C++ support is derived from AppCode's ObjectiveC support.

It's best to kill two birds with one stone and make a scheme for C/C++/ObjectiveC/ObjectiveC++.