jkbrzt / rrule

JavaScript library for working with recurrence rules for calendar dates as defined in the iCalendar RFC and more.
https://jkbrzt.github.io/rrule
Other
3.3k stars 513 forks source link

Monthly recurrence not working when targeting days that might not exist on certain months (eg.: every month on the 31th.. doesn't exist for june) #343

Closed JD10NN3 closed 5 years ago

JD10NN3 commented 5 years ago

When we are using a MONTHLY recurrence targeting the 29, 30 or 31 of month, the recurrence do not work on month that those values doesn't exists... Take a look at the screenshot.

image

I expected the recurrence to move on the last day of june because that the 31 doesn't exist for that month.

"rrule": "^2.6.0", Ubuntu $ date Sun May 26 09:41:42 DST 2019

JD10NN3 commented 5 years ago

image

image

davidgoli commented 5 years ago

This is correct behavior according to the RFC. If you want to target the last day of the month, try bymonthday=-1.

On Sun, May 26, 2019 at 6:42 AM Jonathan Dionne notifications@github.com wrote:

When we are using a MONTHLY recurrence targeting the 29, 30 or 31 of month, the recurrence do not work on month that those values doesn't exists... Take a look at the screenshot.

[image: image] https://user-images.githubusercontent.com/784590/58382543-97804300-7f99-11e9-84c8-68d38f49a40f.png

I expected the recurrence to move on the last day of june because that the 31 doesn't exist for that month.

"rrule": "^2.6.0", Ubuntu $ date Sun May 26 09:41:42 DST 2019

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jakubroztocil/rrule/issues/343?email_source=notifications&email_token=AAAK46QEKHDXUKCVVSWUMNTPXKHUVA5CNFSM4HPWWLI2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GV4TUAA, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAK46XHNAV5BSYFQXFZZODPXKHUVANCNFSM4HPWWLIQ .

JD10NN3 commented 5 years ago

You're right about the RFC.

Thanks for the trick with bymonthday, it's working 😄