search

jkbrzt / rrule

JavaScript library for working with recurrence rules for calendar dates as defined in the iCalendar RFC and more.
https://jkbrzt.github.io/rrule
Other
3.34k stars 513 forks source link

Simply rerelease v2.6.4 as v2.6.6 #417

Closed maconfr closed 4 years ago

maconfr commented 4 years ago

For users of the package, the current situation is unfortunate. A simple workaround, which is more convenient for the users of this package, would be to republish the working version as v2.6.6.

Maybe it is also possible to mark v2.6.4 as "latest" at npm or delete the broken version?

Woodz commented 4 years ago

You can not delete a broken version. npm packages are cached throughout the Internet, including on developers machines and build agents. The correct approach to a broken version is to release a new fixed version (either fixing the bug or rolling the changes back). A good article to read is https://doughellmann.com/blog/2016/02/25/so-youve-released-a-broken-package-to-pypi-what-do-you-do-now/.

konrad-garus commented 4 years ago

Yes please!

Jogai commented 4 years ago

Yes, like I said before: https://github.com/jakubroztocil/rrule/issues/416#issuecomment-679013893

abbathaw commented 4 years ago

Any idea when this will be fixed?

Jaimeloeuf commented 4 years ago

Just tagging the key contributors, if anyone sees it to help to release a new version on npm. Since the roll back also means that the issues previously fixed by v2.6.5 are now still present in v2.6.4.

It would be great to have a new version to fix all these and the underlying issue of 2.6.5 else, it would be great to have v2.6.4 as the latest version first, since tools like https://www.npmjs.com/package/npm-check-updates will still use v2.6.5 even if it is marked as deprecated!

@davidgoli @jakubroztocil @david-golightly-leapyear @arolson101

jkbrzt commented 4 years ago

I’m sorry about about the broken release. I thought marking it as deleted on npm would have a similar effect like yanking a Python package. I’ve just released 2.6.6 that should be good.