what happens when luxon 2.x is released?

jkbrzt / rrule

JavaScript library for working with recurrence rules for calendar dates as defined in the iCalendar RFC and more.

https://jkbrzt.github.io/rrule

Other

3.3k stars 513 forks source link

what happens when luxon 2.x is released? #471

Closed bartvde closed 2 years ago

bartvde commented 3 years ago

I see that luxon will soon create v2, which will be a breaking change. Will this project move its optional dependency to v2? Are there any plans for that, or not?

CrOrc commented 3 years ago

The way luxon is used https://github.com/jakubroztocil/rrule/blob/286422ddff0700f1beb2e65cebff3421cc698aac/src/datewithzone.ts#L36-L41 Used api is compatible with luxon v2

bartvde commented 2 years ago

can we then update the optional dependency to accept 2.x as well?

davidgoli commented 2 years ago

The dependency on Luxon has been removed in 2.7.0.