jkbrzt / rrule

JavaScript library for working with recurrence rules for calendar dates as defined in the iCalendar RFC and more.
https://jkbrzt.github.io/rrule
Other
3.29k stars 514 forks source link

fix(cache): cache key comparison ignores milliseconds #490

Closed hgrsd closed 2 years ago

hgrsd commented 2 years ago

See #489. The comparison used for cache keys ignores milliseconds, leading to false positive cache hits.

In this PR I've changed the comparison strategy to compare the unix timestamps of the relevant dates instead. Let me know whether you think this is the right approach :)

Thanks for contributing to rrule!

To submit a pull request, please verify that you have done the following:

hgrsd commented 2 years ago

Hello @jakubroztocil @lyschoening @davidgoli 👋 I'd be grateful for a review and your view on the proposed change :) Thanks in advance!

hgrsd commented 2 years ago

@jakubroztocil @lyschoening @davidgoli just checking in to see if you have had any time to take a look at this? Let me know!

jkbrzt commented 2 years ago

Thanks!

hgrsd commented 2 years ago

Thanks for merging! 😃 Do you have a sense of when this might be released? Anything I can do to help do that?