fix: infinite loops in iter when interval is undefined - Githubissues

jkbrzt / rrule

JavaScript library for working with recurrence rules for calendar dates as defined in the iCalendar RFC and more.

https://jkbrzt.github.io/rrule

Other

3.29k stars 514 forks source link

fix: infinite loops in iter when interval is undefined #494

Open theninadoge opened 2 years ago

theninadoge commented 2 years ago

This fixes the issue described in #481.

The issue can be reproduced by create an rrule with an interval of undefined or null (overwriting the default 1), and then calling after, between, before

iCalendar RFC states that interval should be a positive integer, so this fix ensures that if not present interval is set back to the default of 1.

Thanks for contributing to `rrule`!

To submit a pull request, please verify that you have done the following:

[x] Merged in or rebased on the latest master commit
[x] Linked to an existing bug or issue describing the bug or feature you're addressing
[x] Written one or more tests showing that your change works as advertised