Closed davidgoli closed 2 years ago
Merging #508 (a6f6602) into master (17268f4) will decrease coverage by
0.01%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #508 +/- ##
==========================================
- Coverage 88.50% 88.49% -0.02%
==========================================
Files 29 29
Lines 2097 2094 -3
Branches 584 584
==========================================
- Hits 1856 1853 -3
Misses 241 241
Impacted Files | Coverage Δ | |
---|---|---|
src/datewithzone.ts | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 17268f4...a6f6602. Read the comment docs.
In README, there is still a reference to luxon and example https://github.com/jakubroztocil/rrule/blob/remove-luxon/README.md?plain=1#L193
I chose to leave the Luxon reference in the README, since it's mentioned only as an example of a library that can be used to manipulate dates & time zones. Other packages eg. date-fns & day.js could just as easily work in place of Luxon to achieve the same result. I don't think it's necessary for this package's README to give examples in every possible Date library, so I think it's acceptable to leave a single example in an arbitrary package, in this case Luxon.
So does this mean I can do this: dtstart = 2010-01-01T10:00:00 (10am in my local tz) tz = Asia/Kolkata interval = 1 frequency = monthly
And the occurrences returned will be like this: 2010-01-01T10:00:00 2010-02-01T10:00:00 2010-03-01T10:00:00
Addresses https://github.com/jakubroztocil/rrule/issues/501
Note it is now possible to avoid using any 3rd party dependency, since browser support for the
Intl
API is now fairly widespread.