Fix `before()` and `after()` return types

jkbrzt / rrule

JavaScript library for working with recurrence rules for calendar dates as defined in the iCalendar RFC and more.

https://jkbrzt.github.io/rrule

Other

3.29k stars 514 forks source link

Fix `before()` and `after()` return types #524

Closed bill-kerr closed 1 year ago

bill-kerr commented 2 years ago

Currently, rrule.before(...) and rrule.after(...) declare their return type as Date, which is inaccurate. #462 partially addressed this, but it doesn't look like the author is responding to the review request.

This PR simply declares the return type for before and after to be Date | null.

jkepps commented 1 year ago

realizing now that https://github.com/jakubroztocil/rrule/pull/561 is a duplicate of this, but this PR does not update the QueryMethods types

davidgoli commented 1 year ago

Closing in favor of #561 .