Fix bug with option key ordering.

jkbrzt / rrule

JavaScript library for working with recurrence rules for calendar dates as defined in the iCalendar RFC and more.

https://jkbrzt.github.io/rrule

Other

3.29k stars 514 forks source link

Fix bug with option key ordering. #527

Open DarryQueen opened 2 years ago

DarryQueen commented 2 years ago

The logic for isFullyConvertible is sensitive to the key ordering of origOptions because it short-circuits once it sees one of the ignored keys. I imagine this is a bug; the ignored keys should just be skipped over in the loop.

davidgoli commented 10 months ago

@DarryQueen I've merged your other PR [#528] but now this one has conflicts. Please resolve them and I'll merge.

DarryQueen commented 10 months ago

Done, merge conflicts resolved.