Open DarryQueen opened 2 years ago
The logic for isFullyConvertible is sensitive to the key ordering of origOptions because it short-circuits once it sees one of the ignored keys. I imagine this is a bug; the ignored keys should just be skipped over in the loop.
isFullyConvertible
origOptions
@DarryQueen I've merged your other PR [#528] but now this one has conflicts. Please resolve them and I'll merge.
Done, merge conflicts resolved.
The logic for
isFullyConvertible
is sensitive to the key ordering oforigOptions
because it short-circuits once it sees one of the ignored keys. I imagine this is a bug; the ignored keys should just be skipped over in the loop.