jkbrzt / rrule

JavaScript library for working with recurrence rules for calendar dates as defined in the iCalendar RFC and more.
https://jkbrzt.github.io/rrule
Other
3.27k stars 507 forks source link

Wrong rule text when repeat by month and bysetpos is larger than 1 #535

Open Aaron-Lin-74 opened 2 years ago

Aaron-Lin-74 commented 2 years ago

Reporting an issue

darkLord19 commented 1 year ago

@Aaron-Lin-74 did you find solution for this? I am also facing the same issue and for larger than 1 values rrule.after produces invalida date output

smallst commented 1 year ago

same issue. here's the demo output. the all() returns correct day while the nlp output text seems missing bysetpos param. don't very familiar with nlp. but it may not so hard to fix ?

image

smallst commented 1 year ago

i see. byweekday=2MO shows correct second monday whille bysetpos is currently ignored in nlp

pcreehan commented 1 year ago

Also seeing this, not just for bysetpos > 1 but also for bysetpos=-1. Seems the nlp isn't respecting bysetpos parameter at all