search

jkbrzt / rrule

JavaScript library for working with recurrence rules for calendar dates as defined in the iCalendar RFC and more.
https://jkbrzt.github.io/rrule
Other
3.29k stars 514 forks source link

toText missing BYSETPOS #629

Open gbulfon opened 2 months ago

gbulfon commented 2 months ago

Hello, I think I found a bug.

RRule.fromString("FREQ=MONTHLY;BYSETPOS=3;BYDAY=TH;INTERVAL=3;UNTIL=20240730T220000Z").toText();

returns : 'every 3 months on Thursday until July 30, 2024' should be : 'every 3 months on 3rd Thursday until July 30, 2024'

Is the BYSETPOS check missing?

Corepex commented 1 month ago

It seems that the text version of BYSETPOS is missing in every configuration

Corepex commented 1 month ago

This should be the solution: https://github.com/jkbrzt/rrule/pull/504

gbulfon commented 1 month ago

This should be the solution: #504

Yes I found it but it's not been incorporated. I had to patch it myself. Why?