jkcfg / jk

Configuration as Code with ECMAScript
https://jkcfg.github.io
Apache License 2.0
404 stars 30 forks source link

Can the jkcfg/build image use jkcfg/prebuilt? #350

Open squaremo opened 4 years ago

squaremo commented 4 years ago

This would speed it up a bit.

dlespiau commented 4 years ago

I originally used the docker image to generate the linux prebuilt binaries as a way to have reproducible builds that don't depend on the developer environment. That said we could have two dockerfiles, one to build things, one using the prebuilt?

squaremo commented 4 years ago

Ah, so something like,

jkcfg/prebuild -> builds or downloads all binaries etc. for prebuilt
jkcfg/build -> uses prebuilt for jk build

(OK the prebuild v. prebuilt would be confusing, but with different names ...)

dlespiau commented 4 years ago

Yes! That's precisely what I had in mind :)

squaremo commented 4 years ago

Actually the prebuilt repo could host the prebuild Dockerfile, then the build image could just copy the bits out of the prebuild image. And we should probably use specific digests when we refer to images.

dlespiau commented 4 years ago

Ah yes, even better!