search

jkcfg / kubernetes

Apache License 2.0
25 stars 6 forks source link

Depend on std #32

Closed squaremo closed 5 years ago

squaremo commented 5 years ago

The style of {shorts, chart, overlay} is to make the caller supply procedures (e.g., read) from std or otherwise. This is useful for testing, and possibly in some specialised circumstances, but a bit of a pain most of the time. This PR will make the main entry points use the std library, so they can be used directly.

(Actually shorts is still in its own PR, so just charts and overlay get the treatment).

squaremo commented 5 years ago

CI is failing because tsc doesn't like the fact of @jkcfg/std/merge not having a definition file (it's referred to indirectly, now). At some point, I should add types for that module. However for now, I may have to disable noImplicitAny in this repo.