jkcfg / kubernetes

Apache License 2.0
26 stars 6 forks source link

The typescript example points JK at the .ts file when it should be using the output of tsc (the .js file) #52

Closed lulusrpk closed 4 years ago

errordeveloper commented 4 years ago

It actually doesn't matter, jk run recognises .js as well as .ts.

$ jk run -v guestbook.ts  
wrote redis-master-deployment.yaml
$ jk run -v guestbook.js
wrote redis-master-deployment.yaml
$ 
errordeveloper commented 4 years ago

It turns out the instructions work as they are because the example doesn't have any types. I'll update the instructions now. Thanks for reporting this!