search

jkcfg / kubernetes

Apache License 2.0
25 stars 6 forks source link

fix: another typo #59

Closed brandonkal closed 4 years ago

brandonkal commented 4 years ago

Found another one! I checked all the objects in the kinds file so this should be it.

dlespiau commented 4 years ago

Thanks again! What we should really need to have: validation (eg. against JSON schemas) integrated with the generation of the config files. We have a start of that in the jk standard library, now it needs to propagate to the Kubernetes library :)

brandonkal commented 4 years ago

FWIW, I found the typos by running struct2ts (interface output) on the koki/short repo. Then:

type AllAny<T> = { [P in keyof T]-?: any }
// Annotated constants
export const podSpec: AllAny<st.Pod> = {

That then gave me some type errors due to the "status" fields being missing. Added those in to get tserver to move on and then found the typos.

dlespiau commented 4 years ago

Nice hack!

Time to ship!