search

jkcshea / ivmte

An R package for implementing the method in Mogstad, Santos, and Torgovitsky (2018, Econometrica).
GNU General Public License v3.0
18 stars 2 forks source link

Change 'lpsolver' to 'solver' #197

Closed jkcshea closed 3 years ago

jkcshea commented 3 years ago

Since we're no longer only using Gurobi and CPLEX for LP problems, it seems confusing to have all these lpsolver arguments. So those will be changed to just solver, or solver.options.

This affects the options: lpsolver lpsolver.options lpsolver.presolve lpsolver.options.criterion *lpsolver.options.bounds

Apologies to @johnnybonney @cblandhol for the inconvenience caused.

a-torgovitsky commented 3 years ago

Maybe for "backwards compatibility" it is better to just introduce new options while keeping the lpsolver ones? Then alias the lpsolver ones to solver and issue a warning to the user that the option is deprecated?

Also, probably some of the error/warning messages need to be adjusted to reflect the same issue.

jkcshea commented 3 years ago

Maybe for "backwards compatibility" it is better to just introduce new options while keeping the lpsolver ones? Then alias the lpsolver ones to solver and issue a warning to the user that the option is deprecated?

Done!

And we have a lot of error and warning messages, as well as documentation. So I'll be working on those.