Open dan-jensen opened 3 months ago
The changes involve updating the regex pattern for validating DHL E-Commerce tracking numbers in the couriers/dhl.json
file. The original single regex has been replaced with an array of two regex patterns to accommodate different formats of valid tracking numbers. Additionally, three new valid tracking numbers have been added to the test numbers section for enhanced validation.
File | Change Summary |
---|---|
couriers/dhl.json | Changed regex from a string to an array of strings; added three new valid tracking numbers. |
Objective | Addressed | Explanation |
---|---|---|
Valid DHL eCommerce tracking numbers should pass validation (#83) | ✅ |
🐰 In the land of DHL, the numbers now flow,
With patterns updated, they’re ready to go!
New digits added, a tracking delight,
E-Commerce journeys take wing in the night!
Hop along, dear friends, let the parcels play,
Validation's a breeze, hip-hip-hooray!
🌟
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
This is intended to add support for DHL eCommerce tracking numbers that are 14 digits, which exist in Europe if nowhere else. This resolves https://github.com/jkeen/tracking_number/issues/83
WARNING: Do not merge, there is a problem to resolve.
Summary by CodeRabbit
New Features
Bug Fixes