search

jkeen / tracking_number_data

Shared data for cross platform tracking number detection
MIT License
114 stars 38 forks source link

ontrac tracking number not detected #17

Closed martinipsy closed 1 year ago

martinipsy commented 6 years ago

Hey! Congralations for this great gem, you did an awesome job!

I found an ontrac tracking number that is not detected by the gem: D10011326755777

I've tested others starting with D and they don't work either. what do you think?

jkeen commented 6 years ago

Looks like the have a new tracking number type. Do you have other examples of the D numbers so I can add a new type?

martinipsy commented 6 years ago

Sure! D10011354453707 D10011345983010 D10011342332145

kktsvetkov commented 5 years ago

I've looked for regex patterns for OnTrac and it seems that only the first character is either C or D: https://www.trackingmore.com/tracking-status-detail-en-253.html

jkeen commented 1 year ago

Started PR #61 to try and take a crack at the check digit algorithm. FWIW the test suite now will now actually run through all the example numbers and algorithms, so if anyone wants to take a crack at changing that JSON until the tests pass, feel free

jkeen commented 1 year ago

Figured it out