search

jkeirstead / scholar

Analyse citation data from Google Scholar
Other
312 stars 83 forks source link

restore pubid #97

Closed conig closed 3 years ago

conig commented 3 years ago

As mentioned in issue #96, get_publications() is currently returning all pubids as NA.

I suspect google has modified the page layout. The following commit restores pubid.

conig commented 3 years ago

I've also added a commit to restore get_complete_authors() functionality which was also affected by the restructure.

jefferis commented 3 years ago

Thanks a lot for this fix @conig! It seems that there is at least one other place that is affected (get_article_cite_history) and this was causing the github actions build failure for your PR. This now works for me locally.

jefferis commented 3 years ago

@GuangchuangYu, I guess this is a fairly important fix. Perhaps you could review?

GuangchuangYu commented 3 years ago

thanks.