search

jkeiser / knife-essentials

Knife commands to treat the Chef server like a filesystem
Apache License 2.0
81 stars 26 forks source link

Exception when uploading a frozen cookbook, but not the exception you expect #97

Closed jtimberman closed 11 years ago

jtimberman commented 11 years ago

I'd expect an exception about the 409 conflict. However, I wouldn't expect an error about ui (Which would handle printing out a message about this.

INFO: HTTP Request Returned 409 Conflict: The cookbook workstation at version 1.2.2 is frozen. Use the 'force' option to override.
/Users/jtimberman/.rbenv/versions/1.9.3-p327/lib/ruby/gems/1.9.1/gems/knife-essentials-1.1.1/lib/chef_fs/file_system/cookbooks_dir.rb:72:in `rescue in upload_cookbook_from': undefined local variable or method `ui' for #<ChefFS::FileSystem::CookbooksDir:0x007fd5db4a7f00> (NameError)
  from /Users/jtimberman/.rbenv/versions/1.9.3-p327/lib/ruby/gems/1.9.1/gems/knife-essentials-1.1.1/lib/chef_fs/file_system/cookbooks_dir.rb:66:in `upload_cookbook_from'
    from /Users/jtimberman/.rbenv/versions/1.9.3-p327/lib/ruby/gems/1.9.1/gems/knife-essentials-1.1.1/lib/chef_fs/file_system/cookbook_dir.rb:166:in `copy_from'
    from /Users/jtimberman/.rbenv/versions/1.9.3-p327/lib/ruby/gems/1.9.1/gems/knife-essentials-1.1.1/lib/chef_fs/file_system.rb:343:in `copy_entries'
    from /Users/jtimberman/.rbenv/versions/1.9.3-p327/lib/ruby/gems/1.9.1/gems/knife-essentials-1.1.1/lib/chef_fs/file_system.rb:144:in `block in copy_to'
    from /Users/jtimberman/.rbenv/versions/1.9.3-p327/lib/ruby/gems/1.9.1/gems/knife-essentials-1.1.1/lib/chef_fs/parallelizer.rb:94:in `call'
    from /Users/jtimberman/.rbenv/versions/1.9.3-p327/lib/ruby/gems/1.9.1/gems/knife-essentials-1.1.1/lib/chef_fs/parallelizer.rb:94:in `process_input'
    from /Users/jtimberman/.rbenv/versions/1.9.3-p327/lib/ruby/gems/1.9.1/gems/knife-essentials-1.1.1/lib/chef_fs/parallelizer.rb:69:in `each'
    from /Users/jtimberman/.rbenv/versions/1.9.3-p327/lib/ruby/gems/1.9.1/gems/knife-essentials-1.1.1/lib/chef_fs/file_system.rb:421:in `to_a'
    from /Users/jtimberman/.rbenv/versions/1.9.3-p327/lib/ruby/gems/1.9.1/gems/knife-essentials-1.1.1/lib/chef_fs/file_system.rb:421:in `parallel_do'
    from /Users/jtimberman/.rbenv/versions/1.9.3-p327/lib/ruby/gems/1.9.1/gems/knife-essentials-1.1.1/lib/chef_fs/file_system.rb:141:in `copy_to'
    from /Users/jtimberman/.rbenv/versions/1.9.3-p327/lib/ruby/gems/1.9.1/gems/knife-essentials-1.1.1/lib/chef/knife/upload_essentials.rb:53:in `block in run'
    from /Users/jtimberman/.rbenv/versions/1.9.3-p327/lib/ruby/gems/1.9.1/gems/knife-essentials-1.1.1/lib/chef/knife/upload_essentials.rb:52:in `each'
    from /Users/jtimberman/.rbenv/versions/1.9.3-p327/lib/ruby/gems/1.9.1/gems/knife-essentials-1.1.1/lib/chef/knife/upload_essentials.rb:52:in `run'
    from /Users/jtimberman/.rbenv/versions/1.9.3-p327/lib/ruby/gems/1.9.1/gems/chef-11.4.4/lib/chef/knife.rb:460:in `run_with_pretty_exceptions'
    from /Users/jtimberman/.rbenv/versions/1.9.3-p327/lib/ruby/gems/1.9.1/gems/chef-11.4.4/lib/chef/knife.rb:173:in `run'
    from /Users/jtimberman/.rbenv/versions/1.9.3-p327/lib/ruby/gems/1.9.1/gems/chef-11.4.4/lib/chef/application/knife.rb:123:in `run'
    from /Users/jtimberman/.rbenv/versions/1.9.3-p327/lib/ruby/gems/1.9.1/gems/chef-11.4.4/bin/knife:25:in `<top (required)>'
    from /Users/jtimberman/.rbenv/versions/1.9.3-p327/bin/knife:23:in `load'
    from /Users/jtimberman/.rbenv/versions/1.9.3-p327/bin/knife:23:in `<main>'
jkeiser commented 11 years ago

Fixed in 1.2!