jkelleyrtp / dw1000-rs

Rust driver crate for the Decawave DW1000 UWB transceiver
49 stars 11 forks source link

Feat: bump dependency versions, fix examples, move to defmt, new examples #145

Closed jkelleyrtp closed 2 years ago

jkelleyrtp commented 2 years ago

I've verified that these examples do work:

Screen Shot 2021-12-03 at 3 17 13 AM

Updates:

After this PR is in, I'd like to start adding better support for antenna calibration (resolve #122) and some of the other low-hanging fruit in the issues tab.

Addresses:

hannobraun commented 2 years ago

Thank you, @jkelleyrtp, this is awesome!

Just ping me once this is ready, I'll do a full review then. If you want feedback about anything specific in the meantime, please let me know.

jkelleyrtp commented 2 years ago

Thank you, @jkelleyrtp, this is awesome!

Just ping me once this is ready, I'll do a full review then. If you want feedback about anything specific in the meantime, please let me know.

I'm just about done, but there's some noise because of how the crate is formatted. I've opened #147 as its own PR which will hopefully make this PR smaller.

Kethku commented 2 years ago

Very excited for this :)

jkelleyrtp commented 2 years ago

WRT resolving conflicts: do you prefer rebase or merge?

hannobraun commented 2 years ago

WRT resolving conflicts: do you prefer rebase or merge?

I prefer rebase before I submitted a review. After I submitted a review, I prefer additional changes to added as new commits.

jkelleyrtp commented 2 years ago

Thank you, @jkelleyrtp, this is great!

I did a quick review, and can't find anything wrong (although I did leave one comment earlier, which turned out to be redundant). Since you've tested all the examples, I'm happy to merge this!

One nit pick for future reference: This would have been nicer to review, if there had been more focused commits, i.e. one for updating the dependencies, one for defmt, one for the new examples. But this PR overall was small enough to make the review still manageable, so no big deal.

Thanks again!

Ah yeah, I ended up rebasing everything into the single commit (old habits). Will focus on smaller commits in the future. Thanks! Hoping to add more soon.