jkennedy1980 / clang-scanbuild-plugin

Jenkins plugin which enables static analysis of XCode projects using Clang scan-build
MIT License
10 stars 29 forks source link

Make sure to pass environment to scan-build #3

Closed tru closed 12 years ago

tru commented 12 years ago

Since I am no Java developer, I hope my code doesn't offend you :)

But this supports to pass things like BUILD_NUMBER and friends to the actual clang-command.

jkennedy1980 commented 12 years ago

Tobias, I just submitted plugin version 1.3 to Jenkins. It should show up in the update center sometime tomorrow. Thanks for the contribution.

tru commented 12 years ago

Great! The other fix in 1.3 was actually something I was thinking about doing as well :)

jkennedy1980 commented 12 years ago

Cool. Take a look at the code if you have time. There is a little problem with the Jenkins ArgumentListBuilder when the user passes in an argument that has a quoted space [--use-cc=which clang]. You'll see my comment about it in ScanBuildCommand.java. I figured I'd put in an easy fix and see if people have trouble with it. ArgumentListBuilder just checks the args for a space and adds double quotes if one is found which breaks the command above.

Thanks for you help.