search

jkent / frogfs

Fast Read-Only General-purpose File System (ESP-IDF and ESP8266_RTOS_SDK compatible)
https://frogfs.readthedocs.io
Mozilla Public License 2.0
25 stars 32 forks source link

CONFIG parameter broken in target_add_frogfs (next branch) #48

Closed valkuc closed 1 year ago

valkuc commented 1 year ago

Hi. I'm trying to use target_add_frogfs with CONFIG parameter but it results in wrong invocation of mkfrogfs.py as it is necessary to pass additional --config cmd line argument that is missing in functions.cmake file. As result the next error is generated in build output:

usage: mkfrogfs.py [-h] [--config CONFIG] ROOT OUTPUT
mkfrogfs.py: error: unrecognized arguments: E:/Espressif/workspace/httpd/build/frogfs.bin

A quick fix is to modify line 45 in functions.cmake to look like:

COMMAND ${CMAKE_COMMAND} -E env CMAKEFILES_DIR=${BUILD_DIR}/CMakeFiles ${Python3_VENV_EXECUTABLE} ${frogfs_DIR}/tools/mkfrogfs.py ${directories} --config ${ARG_CONFIG} ${path} ${output}.bin

(pay attention --config added here)

But then it will break compilation without CONFIG argument.

jkent commented 1 year ago

Should be good to go! Thanks for catching this.