jkent / frogfs

Fast Read-Only General-purpose File System (ESP-IDF and ESP8266_RTOS_SDK compatible)
https://frogfs.readthedocs.io
Mozilla Public License 2.0
25 stars 32 forks source link

suggestion: use project_include.cmake to automatically import frogfs functions #54

Closed igrr closed 11 months ago

igrr commented 11 months ago

For IDF-specific CMake projects, this part of frogfs usage:

include(components/frogfs/cmake/functions.cmake)   # <<<
target_add_frogfs(my_project.elf html NAME frogfs CONFIG frogfs.yaml)

could be simplified by adding a project_include.cmake file into the component root directory. IDF build system includes project_include.cmake files, making the functions defined there available in component and project CMakeLists files.

Here are some examples:

(Generic CMake projects can continue using include(...), as this is more idiomatic in CMake. For IDF-specific projects, though, making the function available immediately after adding the component to the build is more common.)

jkent commented 11 months ago

The README.md you referenced is out of date. Major development has been occurring in the next branch. However I have restructured this project as you have suggested. Thanks @igrr