jkgng / minify

Automatically exported from code.google.com/p/minify
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

IE special rule kills the output #181

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Minify version: 2.1.3.
PHP version: 5.2.12.

What steps will reproduce the problem?
1. just add a block like this ino the css
/* IE FORM ELEMENT FIX */
* html input.checkbox {
    margin:-1px -2px;
} 

Expected output:
something like
* html input.checkbox{margin:-1px -2px;} 
^keeping the spaces after '*' and between margins too
Actual output:
*html input.checkbox{margin:-1px-2px;} 

Original issue reported on code.google.com by joe7j...@gmail.com on 21 May 2010 at 10:10

GoogleCodeExporter commented 9 years ago
Replace /min/lib/Minify/CSS/Compressor.php with this new version:
http://code.google.com/p/minify/source/browse/branches/2.1.4/min/lib/Minify/CSS/
Compressor.php

With it I get this valid output:

* html
input.checkbox{margin:-1px -2px}

If this doesn't help, could you attach the whole problem file or whittle it 
down to
the smallest case where the error occurs?

Original comment by mrclay....@gmail.com on 22 May 2010 at 2:45

GoogleCodeExporter commented 9 years ago
Sorry, all i'm using from your package is the
http://code.google.com/p/minify/source/browse/trunk/min/lib/JSMin.php file 
itself
with a constructor and then min() call.
Is this something wrong with this approach?
All i want is to have the file minified after all.

Original comment by joe7j...@gmail.com on 22 May 2010 at 3:51

GoogleCodeExporter commented 9 years ago
ugh, me being a noob here i guess, is that for JS only? ;>

Original comment by joe7j...@gmail.com on 22 May 2010 at 3:57

GoogleCodeExporter commented 9 years ago
Yes :) You want Minify_CSS_Compressor for CSS. I've seen at least one framework
trying to use JSMin for CSS (with very buggy results) so you're not the first.

Original comment by mrclay....@gmail.com on 22 May 2010 at 4:46

GoogleCodeExporter commented 9 years ago
Gotcha, thanks for the heads up & sorry for being noob ;>
Ticket is invalid indeed

Original comment by joe7j...@gmail.com on 22 May 2010 at 5:46