search

jkhsjdhjs / node-fetch-cookies

node-fetch wrapper that adds support for cookie-jars
MIT License
28 stars 16 forks source link

Transmit cookies on redirect #6

Closed Farkal closed 4 years ago

Farkal commented 4 years ago

Fix https://github.com/jkhsjdhjs/node-fetch-cookies/issues/4

Farkal commented 4 years ago

I have made the adjustments you ask for ;) For the typo i suggest you to add a .prettierrc (i use prettier) it's easier to get the right format (just ask vscode to format the file after adding some code and can be checked with eslint pre-commit hook)

jkhsjdhjs commented 4 years ago

Thanks! Also thanks for the hint with prettier, didn't know about it. Will check it out! Now there's just one more issue in the code: options on line 41 can be null now, since you changed the condition for wantFollow. This will result in an error, when all supplied cookie jars are empty.

Farkal commented 4 years ago

Yeah sorry :disappointed: it should be fixed

jkhsjdhjs commented 4 years ago

Thanks, merged!