Open jkibele opened 6 years ago
So, the RiverGraph
object currently includes the coastline because it needs a concept of "river mouth" that is distinct from just a dead end. It might be cleaner to, if possible, use GraphBuilder
to generate a RiverGraph
that is pruned of any extraneous dead ends. Then RiverGraph
could treat all deadends as river mouths in distance calculations.
Following up on this issue, I've decided I need to redesign the
pyriv.graph_prep
module andGraphBuilder
object a bit. Basically,GraphBuilder
needs to be able to handle the following tasks:In order to do this across all likely scenarios, it has to account for the following cases:
I think the work-flow needs to looks something like this:
GraphBuilder
object with river shp, coastline (polygon) shp, and river_mouth_tolerance value.