search

jkimdon / cohotikimeals

fresh start on meal integration with tiki
GNU General Public License v3.0
0 stars 0 forks source link

review Nov 17 meal processing #75

Open stonylohr opened 5 years ago

stonylohr commented 5 years ago

Report from Nic below, and screen shot attached. I'll give additional thoughts as a separate comment. 2018.11.17_Meal summary_breakfast.pdf

Subject: Meal report Nov 17, 2018 - system error + my mistake

As mentioned last week, here's a summary of what i was describing.

Upon submitting my meal report i got an unusual error. Unfortunately i did not take a screenshot of the error message. When i went back to submit the meal report again, i made the following observations:

  1. the walk-ins i had selected in my first pass were now automatically selected as sign-up diners
  2. the pantry usage/items however were not automatically selected - so i re-entered those
  3. i had forgotten to add a couple of items on my first pass, so i expected the total expenses to increase on the second attempt, but somehow it was lower than the first submission ($2.63 instead of $2.48 if i remember correctly).

I have attached the meal summary that went through (2nd pass).

2nd issue on this meal - this one is my bad... I completely forgot to add the bread from Wild Yeast as an expense on the meal report. So that means diners won't be charged for it ($10). Is there a way for you/Joey to edit the meal report to add this expense? I am not putting this as a purchase on my reimbursement form.

Please let me know your thoughts especially on the 2nd issue.

stonylohr commented 5 years ago

Here's my initial take on various parts of this...

Issue 2 (forgot to add Wild Yeast bread expense): Joey, can I just insert a row into cohomeals_food_expenditures for this, or are there additional steps needed as well? Note that I need to get clarification from Nic about whether he paid Wild Yeast for the bread (which would affect who the shopper is).

Issue 1, part 1 (walk-ins show as sign-up diners): I think this is not likely a concern, because walk-ins and regular diners are treated the same in the new system, other than the initial signup. This hints that, whatever went wrong in the original submission happened after at least some processing of walk-ins. Issue 1, part 2 (pantry usage/items however were not automatically selected): This hints that the error in the original submission happened before or during processing of pantry items. It doesn't otherwise feel especially worrisome to me. Issue 1, part 3 (more items, but lower per-adult cost): One innocuous possibility for this is if pantry prices changed between the attempts. If it's a bug, there are any number of possibilities. Probably call it ok?

stonylohr commented 4 years ago

Meal link: https://tiki.cohoecovillage.org/coho_meals-view_entry.php?id=2779&mealdatetime=1542472200