jkirkcaldy / plex-utills

Manage your Plex library automatically
MIT License
324 stars 24 forks source link

Atmos / DTS:X support #34

Closed KrunchMuffin closed 2 years ago

KrunchMuffin commented 3 years ago

Would it be possible to add support for these object sound formats? Plex won't add it ever.

ApfelBirneKreis commented 3 years ago

Would love to see this! Bump!

jkirkcaldy commented 3 years ago

As the script uses the plex api to find 4k files, there is currently no way of seeing whether a file has atmos/dts:x soundtracks through the api.

I can look into whether it is possible to add this outside of plex.

KrunchMuffin commented 3 years ago

As a start, you should be able to identify 7.1 since Plex has that info.

On Mon, Sep 6, 2021, 10:12 AM jkirkcaldy @.***> wrote:

As the script uses the plex api to find 4k files, there is currently no way of seeing whether a file has atmos/dts:x soundtracks through the api.

I can look into whether it is possible to add this outside of plex.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jkirkcaldy/plex-utills/issues/34#issuecomment-913680967, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH5HDNULHSOISHGRUHRRYDUATD5RANCNFSM5CEE6JUQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

jkirkcaldy commented 2 years ago

I have a way of getting whether or not a file has atmos, I am weary of adding another banner, as then you would have quite a lot going on so I am open to suggestions on how you'd want it shown

KrunchMuffin commented 2 years ago

Some options if possible

I don't have 4k, so for me something like the mini 4k would be good.

If using 4k banner, then you could do like the HDR but on opposite side.

If using 4k mini, could put a mini audio in top right corner.

Yes, could be a lot going on for some people, but it's all optional and it doesn't bother me.

ApfelBirneKreis commented 2 years ago

I am using HDR and 4k mini with dolby atmos, so like a mini DTS:X and mini Dolby Atmos Symbol on the bottom would be great. Is there a way to also check if HDR is Dolby vision?

jkirkcaldy commented 2 years ago

Bottom of which banner? The 4k or the HDR?

The next release has newly designed HDR banners and the script looks to see which version of HDR is used. So there is a standard HDR banner, a Dolby Vision Banner and a HDR10+ banner

jkirkcaldy commented 2 years ago

Testing this now. Detection is working and the posters look like this:

poster 1637778724

KrunchMuffin commented 2 years ago

sweet, that works

KrunchMuffin commented 2 years ago

Just a small typo I noticed since ur in the code.

Enabled scrpts are shown below:

scripts missing i

KnifeFed commented 2 years ago

Another approach to this could be to combine the HDR/DV banner with the Atmos/DTS:X banner, i.e. having the audio logo next to/underneath the HDR/DV logo. Having three different banners in three different places could potentially look messy. Even now, with two banners, I've encountered some instances where "vital" parts of the poster are partially covered (mainly by the HDR banner).

Furthermore, I think it would be really nice to have a banner with only HDR/DV (+ audio). In my case, for example, I don't have any media that's HDR/DV and not 4K – making a dedicated 4K banner redundant. The ideal for me would be to have a single banner that shows one of:

Just my ¢2 :)

KrunchMuffin commented 2 years ago

That won't work for me. I don't have 4k nor do I have HDR/DV.

KnifeFed commented 2 years ago

Ok, so just a single banner with Atmos/DTS:X then.

KrunchMuffin commented 2 years ago

There can only be one object audio type per movie. AFAIK. But I want to distinguish between them both. I don't want one banner that shows both.

KnifeFed commented 2 years ago

Yeah, every time I wrote "HDR/DV" and "Atmos/DTS:X" I meant either-or, i.e. only one of the logos.

ApfelBirneKreis commented 2 years ago

Quick question how do you guys deal with your DV content? Uncompressed?

jkirkcaldy commented 2 years ago

Had a little re-design. Adding them to the bottom of the HDR banners. It needs to be a design that can be used in conjunction with all the existing banners. I think this newer design works well with this. atmos example dtsx example

dtsx only example atmos only example

KnifeFed commented 2 years ago

That is actually the old DTS:X logo. Here is the new one, in monochrome.